Fix: Remove monitored_pids metric from process_monitor#29
Merged
Conversation
- Remove monitored_pids metric from process_monitor.py to eliminate TOML warnings - Document comprehensive CPU usage investigation findings in ADR-005 - Confirm CPU usage metrics DO register correctly in Instana - Evidence shows no bugs in data processing stack - system works as designed - Investigation concluded testing methodology was root cause, not system defects
laplaque
force-pushed
the
fix/remove-monitored-pids-metric
branch
from
923d1ec to
d2327ee
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the monitored_pids metric from the process monitor to eliminate OpenTelemetry validation warnings and updates documentation and workflow to reflect the change.
- Removed
monitored_pidsentry from the metrics dictionary inaggregate_process_metrics(). - Added release notes (both TAG and global) and ADR documenting the CPU investigation.
- Simplified PR validation workflow to call a reusable workflow.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/releases/TAG_v0.1.04.md | Added detailed TAG release notes for version 0.1.04 |
| docs/releases/RELEASE_NOTES.md | Inserted v0.1.04 release entry into global release notes |
| docs/adr/005-cpu-usage-investigation-findings.md | Created ADR for CPU usage investigation findings |
| common/process_monitor.py | Removed "monitored_pids" from aggregated metrics dictionary |
| .github/workflows/pr-validation.yml | Replaced in-file validation steps with a call to reusable workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The plugin was generating warning messages:
Root Cause
The
monitored_pidsmetric was being generated incommon/process_monitor.pybut was not defined in the TOML configuration file (common/manifest.toml). The OpenTelemetry connector validates that all metrics are properly defined before accepting them.Solution
Removed the
monitored_pidsentry from the metrics dictionary inaggregate_process_metrics()function. This metric was only used for debugging purposes and is not needed as a legitimate monitoring metric since:Changes
"monitored_pids": ",".join(process_pids)from metrics dictionaryprocess_pidslist for internal logging purposesTesting
✅ All Tests Passed:
After this change, the warning messages no longer appear in the logs, and all legitimate metrics continue to be processed normally.
Impact