[13.x] Add dispatchSyncIf and dispatchSyncUnless to Dispatchable#59736
Closed
bipinks wants to merge 1 commit intolaravel:13.xfrom
Closed
[13.x] Add dispatchSyncIf and dispatchSyncUnless to Dispatchable#59736bipinks wants to merge 1 commit intolaravel:13.xfrom
bipinks wants to merge 1 commit intolaravel:13.xfrom
Conversation
Member
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
dispatchSyncIfanddispatchSyncUnlessto complete the conditional-dispatch API on theDispatchabletrait.Motivation
Dispatchablealready has conditional variants for the queued dispatch path:…but the synchronous dispatch path has no matching variants. Users who want to conditionally run a job in the current process are forced to an explicit
ifstatement, and the naming ofdispatchIfactively invites a subtle bug:There is no chainable fallback either —
PendingDispatchhas no->sync()method — so the conditional-sync case has no fluent equivalent today.New methods
dispatchSyncIf($boolean, ...$args)Fluentno-op otherwisedispatchSyncUnless($boolean, ...$args)Fluentno-op otherwiseBoth accept a
boolorClosure, matching the exact shape ofdispatchIf/dispatchUnless.Usage
Tests
Added 4 new integration tests in
tests/Integration/Queue/JobDispatchingTest.phpmirroring the existing coverage fordispatchIf/dispatchUnless: boolean + Closure cases for both methods. All 13 tests in the file and 79tests/Bus/tests pass.No breaking changes
New methods only; existing behavior untouched.