Add Token.as_str() to decode bytes token values#1617
Open
apoorva-01 wants to merge 1 commit into
Open
Conversation
Under use_bytes=True a token's value is bytes, so float(token) and other str ops fail. as_str() decodes it so callbacks work the same either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
float(token)breaks withuse_bytes=True:could not convert string to float: Token('NUMBER', b'1'). Token subclasses str, but under use_bytes the value is bytes, so the string is the repr"b'1'", not"1".Added
Token.as_str()that decodes bytes (else returns as-is), sofloat(token.as_str())works either way. Used latin-1 since that's what lark uses for lexer patterns and it won't choke on odd bytes. Can switch if you want.This is the small fix. It doesn't touch the deeper thing where
token.value == tokenis false under use_bytes. Making Token bytes-aware would fix that too, but it's a bigger semantics change, so I kept it contained. Happy to go that way instead. Test parses bytes and checksfloat(token.as_str()), fails without the fix.Closes #1526