docs(skills): clarify minutes routing semantics#591
Open
zhicong666-bytedance wants to merge 1 commit intomainfrom
Open
docs(skills): clarify minutes routing semantics#591zhicong666-bytedance wants to merge 1 commit intomainfrom
zhicong666-bytedance wants to merge 1 commit intomainfrom
Conversation
📝 WalkthroughWalkthroughThis PR updates documentation across the lark-minutes and lark-vc skills to clarify routing and workflows for retrieving meeting minutes and notes. It shifts minute_token retrieval to use Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
domain/vc
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/lark-vc/references/lark-vc-recording.md (1)
108-121:⚠️ Potential issue | 🟡 MinorUse explicit date in Scenario 4 to match current date-handling guidance.
This section’s example still uses
--start yesterday, which conflicts with nearby docs that require concrete dates for deterministic routing.Proposed doc patch
-# 第 1 步：搜索历史会议，拿到 meeting_ids -lark-cli vc +search --query "周会" --start yesterday +# 第 1 步：搜索历史会议，拿到 meeting_ids（示例使用明确日期） +lark-cli vc +search --query "周会" --start 2026-03-10 --end 2026-03-10🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-vc/references/lark-vc-recording.md` around lines 108 - 121, Scenario 4 uses a relative date flag "--start yesterday" in the lark-cli vc +search example which conflicts with the deterministic routing requirement; update the example invocation (the lark-cli vc +search command) to use an explicit concrete date (e.g., ISO date like 2026-04-20 or a clear placeholder such as <YYYY-MM-DD>) instead of "yesterday" so that the search step returns deterministic meeting_ids and the subsequent lark-cli vc +recording and lark-cli minutes +download steps remain reproducible.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@skills/lark-vc/references/lark-vc-recording.md`:
- Around line 108-121: Scenario 4 uses a relative date flag "--start yesterday"
in the lark-cli vc +search example which conflicts with the deterministic
routing requirement; update the example invocation (the lark-cli vc +search
command) to use an explicit concrete date (e.g., ISO date like 2026-04-20 or a
clear placeholder such as <YYYY-MM-DD>) instead of "yesterday" so that the
search step returns deterministic meeting_ids and the subsequent lark-cli vc
+recording and lark-cli minutes +download steps remain reproducible.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cf78564b-970e-4696-95a7-b54e46ff5fe6
📒 Files selected for processing (6)
skills/lark-minutes/SKILL.mdskills/lark-minutes/references/lark-minutes-download.mdskills/lark-minutes/references/lark-minutes-search.mdskills/lark-vc/SKILL.mdskills/lark-vc/references/lark-vc-recording.mdskills/lark-vc/references/lark-vc-search.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
==========================================
+ Coverage 60.92% 61.05% +0.12%
==========================================
Files 399 400 +1
Lines 34089 34130 +41
==========================================
+ Hits 20770 20838 +68
+ Misses 11395 11368 -27
Partials 1924 1924 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@2db1405e5ba4eebac1a998644f75b5f3b28b5e2e🧩 Skill updatenpx skills add larksuite/cli#docs/minutes-skill-routing -y -g |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify the routing between VC meeting notes and minutes metadata in the skill docs.
Also refine the natural-language guidance for "participated minutes" so agents do not under-fetch owner-owned minutes.
Changes
vc +recordingandminutes minutes get, rather thanvc +notesminute_tokensource in the minutes download referenceTest Plan
git diff --checkgo test ./...Related Issues
Summary by CodeRabbit