refactor(orphans): use vim.fn.system argv form instead of io.popen#19
Merged
refactor(orphans): use vim.fn.system argv form instead of io.popen#19
Conversation
Avoids the shell entirely by passing argv to vim.fn.system, and checks vim.v.shell_error before parsing the timestamp. Functionally equivalent to the prior shellescape'd io.popen call. Co-Authored-By: larpi <33772093+larpios@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
io.popen+string.format/shellescapeshell pipeline inlua/larpi/utils/orphans.luawith an argv-formvim.fn.systemcall. This avoids invoking the shell entirely, matches the pattern already used inlua/larpi/lazy.lua, and adds avim.v.shell_errorcheck so a failinggit logno longer gets parsed as a timestamp.Context: done as a small stylistic/hardening cleanup from a security scan of the repo. The prior code was already safe (it used
vim.fn.shellescapeonplugin.dir), so this is a readability and defense-in-depth change, not a vulnerability fix.Review & Testing Checklist for Human
:CheckOrphansin Neovim and confirm the floating window still lists plugins with correct "days ago" values (I could not run Neovim in the sandbox — CI only verifies startup, not this command's runtime behavior).vim.v.shell_error == 0gate is acceptable. This is a minor behavior change: previously any stdout fromgit logwas parsed even if git exited non-zero; now a non-zero exit skips that plugin. In practicegit log -1either succeeds and prints a timestamp or fails and prints nothing to stdout, so behavior should be identical — but worth a conscious sign-off.Notes
styluaconfig (column_width=160, single quotes, 4-space indent)..github/workflows/ci.yml) only exercisesnvim --headless +qastartup, so it won't exercisecheck_orphans— green CI is necessary but not sufficient here.Link to Devin session: https://app.devin.ai/sessions/e5fb96c44f644b0787eb25dfb825d6f1
Requested by: @larpios