Allow an empty injected-field value for TEXT columns#247
Merged
Conversation
larsewi
force-pushed
the
allow-empty-injected-value
branch
from
c542c4e to
7cf0815
Compare
An empty string is a valid TEXT value, but config validation rejected it outright. Drop the up-front empty check and let parse_typed_cell decide: it accepts empty TEXT and still rejects empty NUMBER/BOOLEAN. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
larsewi
force-pushed
the
allow-empty-injected-value
branch
from
7cf0815 to
79b866f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty string is a valid TEXT value, but config validation rejected it up front. This drops the empty check and lets
parse_typed_celldecide -- it accepts empty TEXT and still rejects empty NUMBER/BOOLEAN. Adds unit tests for both.🤖 Generated with Claude Code