Make modification check RFC-compatible#1176
Draft
ConjuringCoffee wants to merge 2 commits intomainfrom
Draft
Conversation
Collaborator
Author
|
This implementation is insufficient. If the RFC function module is not found on the target system, then the checks just don't result in any results. The error must be handled in some way. |
Collaborator
Author
|
(I have not forgotten about this open development. I hope I'll have some time to tackle this soon.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1157
The method
INFORMofZCL_AOC_SUPERcontains logic to check if an object was modified. This only properly worked within non-RFC checks because direct database selections were used.I've encapsulated the existing logic into an RFC-enabled function module.