Skip to content

📝 clarify model script selection in generated outputs#19

Open
clorton wants to merge 1 commit into
mainfrom
model-options
Open

📝 clarify model script selection in generated outputs#19
clorton wants to merge 1 commit into
mainfrom
model-options

Conversation

@clorton

@clorton clorton commented May 14, 2026

Copy link
Copy Markdown
Contributor

Document that --model selects both the epidemiological model and the generated script name (si.py, sir.py, or seir.py).

Update the README and user-facing guides to:

  • describe the default seir.py output more precisely
  • explain when to run si.py or sir.py instead
  • remove wording that implies only SEIR scripts are generated
  • note the documentation change in the changelog

Document that `--model` selects both the epidemiological model and the
generated script name (`si.py`, `sir.py`, or `seir.py`).

Update the README and user-facing guides to:
- describe the default `seir.py` output more precisely
- explain when to run `si.py` or `sir.py` instead
- remove wording that implies only SEIR scripts are generated
- note the documentation change in the changelog
@clorton clorton requested a review from Copilot May 14, 2026 20:30
@clorton clorton self-assigned this May 14, 2026
@clorton clorton added the documentation Improvements or additions to documentation label May 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates user-facing documentation to clarify that --model determines both the epidemiological model variant and the generated script filename.

Changes:

  • Clarifies default seir.py generation and SI/SIR alternatives across guides.
  • Updates run instructions to reference matching si.py, sir.py, or seir.py scripts.
  • Records the documentation clarification in the changelog.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
README.md Clarifies generated model script naming and execution guidance.
docs/userguide.md Updates workflows and editing guidance for model-specific script names.
docs/troubleshooting.md Clarifies replacing seir.py when troubleshooting SI/SIR scripts.
docs/quickstart.md Updates quickstart output and run instructions for model variants.
docs/models.md Adds script-name guidance for running different model variants.
docs/index.md Clarifies the generated script can vary by --model.
docs/configuration.md Updates custom config examples to mention all generated script names.
CHANGELOG.md Notes the documentation clarification under Unreleased.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/models.md
python3 ./seir.py
```

If you generated a different model with `--model`, run `python3 ./si.py` or `python3 ./sir.py` instead.
Comment thread docs/userguide.md
### Understanding Model Outputs

After running the generated model script (e.g., `seir.py`), you'll find several output plots:
After running the generated model script (for example, `seir.py`), you'll find several output plots:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants