Fix/validate hotkey existence in stake move#940
Closed
boskodev790 wants to merge 93 commits intolatent-to:mainfrom
Closed
Fix/validate hotkey existence in stake move#940boskodev790 wants to merge 93 commits intolatent-to:mainfrom
boskodev790 wants to merge 93 commits intolatent-to:mainfrom
Conversation
…ock-owner-alpha Fix/e2e tests for stake locked as owner alpha feat
…urn-settings fix: update max_burn to owner/sudo settable and align no-prompt routing
…eration-mapping fix: `stake add` operation mapping for multi-hotkey and multi-netuid
…est-restrictionsw
Update: Log SHA & other info during release
…y-creator-checks fix(crowdloan): normalize creator checks for proxy actors
…th other packages like ASI (latent-to#911)
…ot-unstake-nonexistent-hks Do not unstake from hotkeys that do not exist on chain
…ister Update/remove pow register
…sk-cache Fix/register limit disk cache
…ey-id-decode Decode hotkey ss58 if bytes
…re-limit-price-is-rao Ensure the call params are not Balance objects
…p-asi-cyscale Resolves the issue with the disk cache
Closes latent-to#925. `stake move` and `stake transfer` previously composed and submitted the extrinsic without verifying that the supplied hotkey SS58 was registered on chain. When a user passed an unregistered key, the failure surfaced as a generic chain-side error after the transaction was already on the network. `stake/add.py` and `stake/remove.py` already perform this pre-flight validation via `subtensor.do_hotkeys_exist`. Mirror that pattern in `move_stake` (checks both origin and destination hotkeys) and `transfer_stake` (checks origin hotkey). `swap_stake` is unaffected since it derives the hotkey from the local wallet rather than user input.
boskodev790
force-pushed
the
fix/validate-hotkey-existence-in-stake-move
branch
from
63b989c to
099fef9
Compare
Contributor
|
I think this is a duplicate of #939 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.