feat(postgres): allow for passing a maintenance database in the url#4152
Open
elituf wants to merge 2 commits intolaunchbadge:mainfrom
Open
feat(postgres): allow for passing a maintenance database in the url#4152elituf wants to merge 2 commits intolaunchbadge:mainfrom
elituf wants to merge 2 commits intolaunchbadge:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally, this would be a flag on the
databasepart of the CLI (in my head, anyway). But doing that properly would require changing thesqlx_core::migrate::MigrateDatabasetrait I think, which seemed like a gargantuan change in comparison to this.Does your PR solve an issue?
closes #2774
Is this a breaking change?
No, it is not a breaking change, as it adds an optional parameter to Postgres database URLs, which uses the existing functionality when omitted.