fix(mysql): use lenient flag comparison for ENUM types#4155
Closed
a4501150 wants to merge 1 commit intolaunchbadge:mainfrom
Closed
fix(mysql): use lenient flag comparison for ENUM types#4155a4501150 wants to merge 1 commit intolaunchbadge:mainfrom
a4501150 wants to merge 1 commit intolaunchbadge:mainfrom
Conversation
TiDB (and potentially other MySQL-compatible databases) may return ENUM columns with additional flags like NOT_NULL or NO_DEFAULT_VALUE. The previous exact flag comparison caused type mismatches even though both sides were valid ENUM types. This change makes ENUM comparison check only that both types have the ENUM flag set, ignoring other flags that don't affect type compatibility. Fixes launchbadge#3750 Refs launchbadge#1241
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TiDB (and potentially other MySQL-compatible databases) may return ENUM columns with additional flags like NOT_NULL or NO_DEFAULT_VALUE. The previous exact flag comparison caused type mismatches even though both sides were valid ENUM types.
This change makes ENUM comparison check only that both types have the ENUM flag set, ignoring other flags that don't affect type compatibility.
Fixes #3750
Refs #1241
Does your PR solve an issue?
Delete this text and add "fixes #(issue number)".
Do not just list issue numbers here as they will not be automatically closed on merging this pull request unless prefixed with "fixes" or "closes".
Is this a breaking change?
Delete this text and answer yes/no and explain.
If yes, this pull request will need to wait for the next major release (
0.{x + 1}.0)Behavior changes can be breaking if significant enough.
Consider Hyrum's Law: