fix: Allow constructing HttpConnectionStrategy with pre-built okHttpCient#96
Open
luanpotter wants to merge 1 commit intolaunchdarkly:mainfrom
Open
fix: Allow constructing HttpConnectionStrategy with pre-built okHttpCient#96luanpotter wants to merge 1 commit intolaunchdarkly:mainfrom
luanpotter wants to merge 1 commit intolaunchdarkly:mainfrom
Conversation
9492036 to
fa67d8b
Compare
Contributor
|
@luanpotter , thank you for reaching out. I'm going to take a look. My initial reaction is this breaks the encapsulation of the |
Author
|
Thanks for considering it @tanderson-ld , I understand the encapsulation concerns. Hopefully there is some way to make it possible to re-use an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now you cannot create a
HttpConnectStrategybased off of an preexistingOkHttpClient. You can create one from scratch and then configure it with client configurers, but there is no way to base it off an existingOkHttpClient, which typically already exists on prior codebase for non-SSE calls.This simple change just exposes the second constructor allowing users to use their existing, pre-configured
OkHttpClientas seed for the SSE setup. That would otherwise not be possible with configurers without changing the entire codebase to use the SSE-specific configurer class, which is a hard sell.This allows us to easily test and try out SSE calls within our existing okHttp infrastructure. I am sorry if this was already possible in some way I failed to see, and would appreciate some guidance instead.