Merged
Conversation
The default retry policy has exponential backoff with jitter. This retry strategy is reset after some maximum retry interval. Previously, once this reset interval occurred, it would continue to reset every future attempt, effectively disabling the exponential backoff algorithm. This should no longer be the case, as we now reset the baseline used for determine when to reset the strategy each time it is replaced with the base strategy.
kinyoklion
approved these changes
Feb 28, 2025
Member
kinyoklion
left a comment
kinyoklion
left a comment
There was a problem hiding this comment.
It would be nice to have some unit tests.
kinyoklion
reviewed
Feb 28, 2025
| assert client.next_retry_delay == initial_delay * 2 | ||
|
|
||
| # Sleeping the threshold should reset the retry thresholds | ||
| sleep(retry_delay_reset_threshold) |
Member
There was a problem hiding this comment.
Maybe a little scary, but I assume we don't have an ability to mock advance time.
kinyoklion
approved these changes
Feb 28, 2025
keelerm84
pushed a commit
that referenced
this pull request
Feb 28, 2025
🤖 I have created a release *beep* *boop* --- ## [1.2.2](1.2.1...1.2.2) (2025-02-28) ### Bug Fixes * Fix SSE delay reset handling ([#39](#39)) ([fd401b5](fd401b5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default retry policy has exponential backoff with jitter. This retry
strategy is reset after some maximum retry interval.
Previously, once this reset interval occurred, it would continue to
reset every future attempt, effectively disabling the exponential
backoff algorithm.
This should no longer be the case, as we now reset the baseline used for
determine when to reset the strategy each time it is replaced with the
base strategy.