feat: Add proxy support including HTTP_PROXY, HTTPS_PROXY detection #115
+285
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces proxy handling functionality for the hyper transport, including automatic instrumentation through environment variables. If HTTPS_PROXY is defined, all HTTPS traffic will potentially be routed through this proxy. If HTTP_PROXY is ALSO specified, then HTTP traffic will be routed through it. However, if HTTP_PROXY is specified without HTTPS_PROXY, then all traffic (http and https) will be routed through the HTTP_PROXY.
Member
|
Looks like CI has a rust edition problem. |
kinyoklion
requested changes
Feb 9, 2026
| /// For HTTPS support or timeout configuration, use [`HyperTransport::builder()`]. | ||
| pub fn new() -> Self { | ||
| pub fn new() -> Result<Self, std::io::Error> { | ||
| //let client = HyperTransportBuilder::default().build_http(); |
Member
There was a problem hiding this comment.
Suggested change
| //let client = HyperTransportBuilder::default().build_http(); |
| let byte_stream: ByteStream = Box::pin(body_to_stream(body)); | ||
| /// Check if the given host matches the no_proxy rules. If this function returns true, the | ||
| /// proxy should be bypassed. | ||
| fn matches(&self, host: &str) -> bool { |
Member
There was a problem hiding this comment.
I am not sure about the matching logic here. If nothing else it wouldn't match other no proxy implementations.
I think others would be doing some parsing of the parts.
I think these would all be different from other implementations.
NO_PROXY=ample.com → matches "example.com"
NO_PROXY=10.0.0.0/8 → won't match "10.1.2.3"
NO_PROXY=localhost → won't match "localhost:8080"
Which would make be hesitant to use the NO_PROXY environment variable.
Member
There was a problem hiding this comment.
Might be good to have tests for this.
I want if we may want to considering looking at https://github.com/jdrouet/no-proxy
Member
Author
There was a problem hiding this comment.
I think just using that crate directly makes a lot of sense, so I've pulled that in.
kinyoklion
reviewed
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces proxy handling functionality for the hyper
transport, including automatic instrumentation through environment
variables.
If HTTPS_PROXY is defined, all HTTPS traffic will potentially be routed
through this proxy.
If HTTP_PROXY is ALSO specified, then HTTP traffic will be routed
through it. However, if HTTP_PROXY is specified without HTTPS_PROXY,
then all traffic (http and https) will be routed through the HTTP_PROXY.