test: fix IntegrationTests compile drift and add CI compile-check#812
Merged
Conversation
The IntegrationTests project had accumulated 64 compile errors because it was never built in CI, so ViewModel/service signature changes silently broke it: - WindowsUpdateViewModel ctor gained a WindowsUpdateService param (#611) - DashboardViewModel ctor gained a TemperatureService param - LogsViewModel.SearchText was renamed to FilterText - DashboardViewModel.Snapshot/CpuLine/MemLine and RequestElevationCommand, WindowsUpdateViewModel.ListFeatureUpdatesCommand were removed/renamed Updated all constructors and rewrote the tests that referenced removed API to assert the current surface. Added a 'Build integration tests (compile check)' step to ci.yml (restore + build only — not run in CI since they touch the live system) so this drift is caught immediately from now on. No production code changed; no release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced by the regression sweep after Round 2b.
Problem
SysManager.IntegrationTestshad 64 compile errors and had been broken for a while — it is the only project never built in CI, so ViewModel/service signature changes silently broke it:WindowsUpdateViewModelctor gained aWindowsUpdateServiceparam (feat: install Windows Update via WUA COM API (replaces PSWindowsUpdate) #611)DashboardViewModelctor gained aTemperatureServiceparamLogsViewModel.SearchText→ renamedFilterTextDashboardViewModel.Snapshot/CpuLine/MemLine,RequestElevationCommand(nowRelaunchAsAdminCommand),WindowsUpdateViewModel.ListFeatureUpdatesCommandFix
OsLine/UptimeLine/CpuName/RamTotalGB,RelaunchAsAdminCommand,FilterText).ci.yml(restore + build only — they are not run in CI because they touch the live system). This catches signature drift immediately going forward.Verification
All four projects build: main, Tests, IntegrationTests, UITests — 0 warnings, 0 errors. No production code changed;
test:/ci:→ no release.