Skip to content

feat: google-knowledge-plugin for Developer Knowledge API integration#697

Open
laurigates wants to merge 4 commits intomainfrom
claude/google-knowledge-api-IWxup
Open

feat: google-knowledge-plugin for Developer Knowledge API integration#697
laurigates wants to merge 4 commits intomainfrom
claude/google-knowledge-api-IWxup

Conversation

@laurigates
Copy link
Owner

Summary

This PR introduces a new plugin that integrates Google's Developer Knowledge API as an MCP server, enabling Claude Code to search and retrieve official Google developer documentation for Firebase, Google Cloud, Android, Maps, and related services.

Key Changes

  • New Plugin Structure: Added google-knowledge-plugin with complete plugin metadata and configuration

    • plugin.json: Plugin manifest with metadata, keywords, and licensing
    • README.md: Overview of plugin capabilities and quick start guide
    • Two complementary skills for setup and usage
  • Setup Skill (google-knowledge-setup): User-invocable skill that guides users through:

    • Enabling the Developer Knowledge API in Google Cloud
    • Creating API keys for authentication
    • Enabling the MCP server
    • Configuring Claude Code with the MCP connection
    • Includes troubleshooting guidance and context-aware checks
  • Search Skill (google-knowledge-search): Auto-discovered skill providing:

    • Comprehensive guidance on when and how to use the Developer Knowledge API
    • Documentation of three MCP tools: search_documents, get_document, batch_get_documents
    • Search strategies for implementation guidance, troubleshooting, comparative analysis, and API references
    • Coverage matrix for Firebase, Google Cloud, Android, Maps, and general Google services
    • Agentic optimization patterns for different research contexts
  • Plugin Registration: Updated marketplace and release configuration

    • Added plugin entry to .claude-plugin/marketplace.json
    • Configured release-please versioning in release-please-config.json
    • Updated plugin manifest in .release-please-manifest.json
    • Updated plugin navigation documentation

Implementation Details

  • Skills use allowed tools appropriate to their function (Bash for setup, Read/Grep for search)
  • Documentation is structured with clear use-case tables, workflow patterns, and quick references
  • Setup skill includes context-aware checks for existing configuration and gcloud availability
  • Search skill provides detailed guidance on MCP tool usage and search strategies for different scenarios
  • Plugin targets integration category in marketplace with comprehensive keyword coverage

https://claude.ai/code/session_017NYLD4cfuWaxTvkagEqPKW

claude and others added 2 commits February 8, 2026 13:13
Add new plugin for Google's Developer Knowledge API MCP server, providing
access to official documentation for Firebase, Google Cloud, Android, and Maps.

Skills:
- google-knowledge-setup: Configure the MCP server with API key and gcloud CLI
- google-knowledge-search: Search and retrieve official Google developer docs

https://claude.ai/code/session_017NYLD4cfuWaxTvkagEqPKW
@github-actions
Copy link
Contributor

Plugin Compliance Review

Plugin plugin.json Frontmatter Size Marketplace Release Config Overall
.claude-plugin

Issues Found

  • ❌ .claude-plugin: Missing .claude-plugin/plugin.json
  • ❌ .claude-plugin: No entry in marketplace.json
  • ❌ .claude-plugin: Not in release-please-config.json packages
  • ❌ .claude-plugin: Not in .release-please-manifest.json

@laurigates laurigates changed the title Add google-knowledge-plugin for Developer Knowledge API integration feat: google-knowledge-plugin for Developer Knowledge API integration Feb 17, 2026
@laurigates
Copy link
Owner Author

Read the output of the failed workflows. Think about the root cause of the errors and warnings. If they are related to the changes in this PR, fix them directly. If they are pre-existing, create GitHub issues for them.
@claude

@claude
Copy link

claude bot commented Feb 17, 2026

Claude finished @laurigates's task in 2m 45s —— View job


Investigation Complete ✓

Tasks

  • Get CI workflow status for this PR
  • Download and analyze failure logs
  • Identify root causes of errors/warnings
  • Fix issues related to this PR's changes
  • Create GitHub issues for pre-existing problems
  • Commit and push fixes

Summary

Failed Workflows Analysis:

  1. Lint Context Commands - Fixed the ERROR in this PR; pre-existing warnings documented in issue
  2. Enforce Conventional Commits - PR title was updated to include feat: prefix and now passes

PR-Related Issue - FIXED ✓

ERROR in google-knowledge-plugin/skills/google-knowledge-setup/SKILL.md:29:

  • Problem: Used pipe operator | in context command: cat ~/.claude.json | grep -A5 google-dev-knowledge
  • Fix: Replaced with find ~ -maxdepth 1 -name '.claude.json' pattern
  • Also fixed: Removed && and || operators from other context commands in the same file
  • Commit: b49cd8b

Pre-existing Issues - Documented

Created issue #698 to track 185+ warnings for shell operators (&&, ||) in context commands across multiple plugins:

Affected plugins: blueprint-plugin, configure-plugin, code-quality-plugin, rust-plugin, health-plugin, api-plugin, documentation-plugin, component-patterns-plugin, container-plugin, and others

Pattern to fix:

# Current (produces warnings):
- File check: !`test -f CHANGELOG.md && echo "EXISTS" || echo "MISSING"`

# Recommended:
- File check: !`find . -maxdepth 1 -name 'CHANGELOG.md' 2>/dev/null`

This is a good first issue as it follows a consistent pattern across all affected files.


| PR branch

…mands

Replace pipe operator in context command with find for file discovery.
Also removed && and || operators to comply with linting rules.

Co-authored-by: Lauri Gates <laurigates@users.noreply.github.com>
@github-actions
Copy link
Contributor

Plugin Compliance Review

Plugin plugin.json Frontmatter Size Marketplace Release Config Overall
.claude-plugin

Issues Found

  • ❌ .claude-plugin: Missing .claude-plugin/plugin.json
  • ❌ .claude-plugin: No entry in marketplace.json
  • ❌ .claude-plugin: Not in release-please-config.json packages
  • ❌ .claude-plugin: Not in .release-please-manifest.json

@laurigates
Copy link
Owner Author

Let's address the recommendations in the comments. Evaluate which pieces of criticism and recommendations are substantive and valid. Research latest related documentation and best practices. Act accordingly and refute invalid points.
Let's fix the rebase merge conflicts to that the PR can be merged to main
@claude

@claude
Copy link

claude bot commented Feb 21, 2026

Claude finished @laurigates's task in 3m 51s —— View job


Analysis and Merge Complete ✓

Tasks

  • Analyze compliance review comments (valid vs invalid)
  • Check git status and merge conflicts
  • Fix merge conflicts with main
  • Fix compliance checker false positive
  • Push updated branch

Compliance Review Analysis

The .claude-plugin errors are a false positive. Root cause: the workflow's regex ^[^/]+-plugin matched .claude-plugin when marketplace.json changed, passing it to the compliance script as if it were a plugin. The auto-detect code path already excluded .claude-plugin via find ... -not -name '.claude-plugin', but the argument-passing code path did not.

Fix applied: Added explicit skip for .claude-plugin in scripts/plugin-compliance-check.sh:295:

# Skip .claude-plugin - it's the root metadata directory, not a plugin
if [ "$plugin" = ".claude-plugin" ]; then
  continue
fi

This matches the documented convention in .claude/rules/shell-scripting.md which explicitly calls out .claude-plugin as a directory to exclude from plugin scans.


Merge Resolution

The branch was behind main by ~50 commits (mostly release chores and new plugins). The merge introduced one conflict in .release-please-manifest.json where both sides modified the terraform-plugin version entry and our branch inserted google-knowledge-plugin:

Resolution Decision
terraform-plugin version Kept 1.3.0 from main (newer)
google-knowledge-plugin: 1.0.0 Preserved (this PR's addition)
feedback-plugin, migration-patterns-plugin Incorporated from main

The auto-merge correctly handled marketplace.json, release-please-config.json, and docs/PLUGIN-MAP.md — all three contain both the new plugins from main and the google-knowledge-plugin from this PR.

Commit: 53d9306


| PR branch

- Resolve merge conflict in .release-please-manifest.json by keeping
  terraform-plugin version from main (1.3.0) while preserving
  google-knowledge-plugin: 1.0.0 addition from this PR
- Fix scripts/plugin-compliance-check.sh to skip .claude-plugin when
  passed as argument - it is the root metadata directory, not a plugin.
  The auto-detect mode already excluded it via find's -not -name filter,
  but the exclusion was missing when plugins were passed as arguments,
  causing false positives in the compliance review bot.

Co-authored-by: Lauri Gates <laurigates@users.noreply.github.com>
@github-actions
Copy link
Contributor

Plugin Compliance Review

Plugin plugin.json Frontmatter Size Marketplace Release Config Overall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants