Merged
Conversation
- Automatically done by VS extension (FCC), but pushing for convenience
There was a problem hiding this comment.
Pull request overview
This PR addresses test/build issues by cleaning up unused empty MSBuild property groups in test project files and updating a protocol roundtrip test payload to match the current VoiceStateProperties shape.
Changes:
- Replaced empty
<PropertyGroup>...</PropertyGroup>blocks with self-closing<PropertyGroup />in multiple test.csprojfiles. - Updated
PlayerUpdatePropertiesTestsJSON to includevoice.channelIdfor roundtrip serialization equality.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Lavalink4NET.Tests/Lavalink4NET.Tests.csproj | Simplifies an empty PropertyGroup to a self-closing element. |
| tests/Lavalink4NET.Rest.Tests/Lavalink4NET.Rest.Tests.csproj | Simplifies an empty PropertyGroup to a self-closing element. |
| tests/Lavalink4NET.Protocol.Tests/Requests/PlayerUpdatePropertiesTests.cs | Adds channelId to the voice JSON used for roundtrip serialization assertions. |
| tests/Lavalink4NET.Protocol.Tests/Lavalink4NET.Protocol.Tests.csproj | Simplifies an empty PropertyGroup to a self-closing element. |
| tests/Lavalink4NET.Lyrics.Tests/Lavalink4NET.Lyrics.Tests.csproj | Simplifies an empty PropertyGroup to a self-closing element. |
| tests/Lavalink4NET.Integrations.LyricsJava.Tests/Lavalink4NET.Integrations.LyricsJava.Tests.csproj | Simplifies an empty PropertyGroup to a self-closing element. |
| tests/Lavalink4NET.Integrations.Lavasrc.Tests/Lavalink4NET.Integrations.Lavasrc.Tests.csproj | Simplifies an empty PropertyGroup to a self-closing element. |
| tests/Lavalink4NET.Integrations.ExtraFilters.Tests/Lavalink4NET.Integrations.ExtraFilters.Tests.csproj | Simplifies an empty PropertyGroup to a self-closing element. |
| tests/Lavalink4NET.InactivityTracking.Tests/Lavalink4NET.InactivityTracking.Tests.csproj | Simplifies an empty PropertyGroup to a self-closing element. |
| tests/Lavalink4NET.Cluster.Tests/Lavalink4NET.Cluster.Tests.csproj | Simplifies an empty PropertyGroup to a self-closing element. |
| tests/Lavalink4NET.Artwork.Tests/Lavalink4NET.Artwork.Tests.csproj | Simplifies an empty PropertyGroup to a self-closing element. |
| tests/Lavalink4NET.Abstractions.Tests/Lavalink4NET.Abstractions.Tests.csproj | Simplifies an empty PropertyGroup to a self-closing element. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.