Conversation
- Add dkimpy to requirements/base.txt (was missing after #205) - Remove thread-unsafe monkey-patch of dkim.parse_pem_private_key; PEM parse cost is negligible vs RSA (~0ms vs ~2.5ms per sign) - Add test_dkim_sign_after_error for signer recovery after errors
Owner
Author
|
I measured this locally with temporary microbenchmarks. Caching the parsed private key does provide a real speedup, but it is small in practice. On this machine:
So the overhead is measurable, but it is only a small fraction of total signing time. I do not think that gain justifies the current implementation based on globally monkey-patching |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dkimpytorequirements/base.txt— was missing after Replace vendored dkim with dkimpy package #205, causingModuleNotFoundErrorfor dev/CI installs viapip install -r requirements/tests.txtdkim.sign()call has negligible cost (~0ms vs ~2.5ms RSA operation), confirmed by benchmark of 1000 signsContext
Review of #205 flagged two issues:
dkimpymissing from repo requirements — fixed