feat: add custom WebSocket message grouping controls#48
Open
948049716 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
1 issue found across 12 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/components/MessageDetails.jsx">
<violation number="1" location="src/components/MessageDetails.jsx:464">
P2: Per-render JSON parsing and regex scanning in grouping logic causes redundant expensive work on every keystroke and render. `getMessageSections()` iterates all messages and calls `extractGroupValues()` which `JSON.parse`s payloads and runs regexes. This repeats on every render (and every keystroke in the grouping inputs with no debounce) causing O(n * parse/regex) cost that can jank the UI with large message histories.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| }); | ||
| }; | ||
|
|
||
| const getMessageSections = () => { |
There was a problem hiding this comment.
P2: Per-render JSON parsing and regex scanning in grouping logic causes redundant expensive work on every keystroke and render. getMessageSections() iterates all messages and calls extractGroupValues() which JSON.parses payloads and runs regexes. This repeats on every render (and every keystroke in the grouping inputs with no debounce) causing O(n * parse/regex) cost that can jank the UI with large message histories.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/components/MessageDetails.jsx, line 464:
<comment>Per-render JSON parsing and regex scanning in grouping logic causes redundant expensive work on every keystroke and render. `getMessageSections()` iterates all messages and calls `extractGroupValues()` which `JSON.parse`s payloads and runs regexes. This repeats on every render (and every keystroke in the grouping inputs with no debounce) causing O(n * parse/regex) cost that can jank the UI with large message histories.</comment>
<file context>
@@ -258,6 +264,288 @@ const MessageDetails = ({
+ });
+ };
+
+ const getMessageSections = () => {
+ const trimmedField = groupField.trim();
+ const trimmedValue = groupValue.trim();
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds custom WebSocket message grouping in the message details view. Users can group messages by any JSON field, optionally filter to a specific field value, choose how groups are sorted, and display an additional custom field next to each group title when available.
Summary by cubic
Adds custom WebSocket message grouping in Message Details to quickly organize traffic. Users can group by any JSON field, filter by a specific value, choose sorting, and show an extra display field on group headers.
en,en-us,zh_CN,zh-cn,zh-tw,ja,de,fr,ko, plus key mappings.Written for commit 70a3a64. Summary will update on new commits. Review in cubic