Minimise content of doxide.hpp header#94
Open
alberto-scolari wants to merge 2 commits intolawmurray:mainfrom
Open
Minimise content of doxide.hpp header#94alberto-scolari wants to merge 2 commits intolawmurray:mainfrom
alberto-scolari wants to merge 2 commits intolawmurray:mainfrom
Conversation
alberto-scolari
force-pushed
the
remove_doxide_header
branch
from
969df0c to
0d138be
Compare
lawmurray
reviewed
Apr 16, 2026
| @@ -1,5 +1,8 @@ | |||
| #include "Doc.hpp" | |||
| #include "DocTokenizer.hpp" | |||
| #include <Log.hpp> | |||
Owner
There was a problem hiding this comment.
This should be #include "Log.hpp"
Owner
|
Thanks @alberto-scolari. I made a very minor comment. I don't have a strong opinion on this to be honest: for projects of this size I usually just try to keep header organisation as simple as possible, as compile times are very fast anyway, and I like to put all the cruft in one place, as I did with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #93 .