Skip to content

chore: Standardize Makefile npm scripts#156

Closed
Bhumikagarggg wants to merge 1 commit into
layer5io:masterfrom
Bhumikagarggg:feature/makefile-pkg-json-standardize
Closed

chore: Standardize Makefile npm scripts#156
Bhumikagarggg wants to merge 1 commit into
layer5io:masterfrom
Bhumikagarggg:feature/makefile-pkg-json-standardize

Conversation

@Bhumikagarggg

@Bhumikagarggg Bhumikagarggg commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Notes for Reviewers

This PR fixes #157

Signed commits

  • Yes, I signed my commits.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the build and maintenance tasks in the Makefile to delegate operations to npm run scripts defined in package.json. It also integrates prettier and markdownlint-cli2 for automated formatting and linting, updates the build configurations, and removes an unused demo markdown file. Feedback on the changes includes a recommendation to correct a duplicated comment for the build-preview target in the Makefile to ensure accurate documentation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread Makefile
build: check-go check-deps
npm run build:production

## Build site for local consumption

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment for build-preview is duplicated from the build target. It should be updated to accurately describe that it builds the preview site.

## Build preview site

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-07-08 00:33 UTC

@Bhumikagarggg Bhumikagarggg force-pushed the feature/makefile-pkg-json-standardize branch from 3a079bf to 6c987e7 Compare July 7, 2026 11:44
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
@Bhumikagarggg Bhumikagarggg force-pushed the feature/makefile-pkg-json-standardize branch from 6c987e7 to 4c67832 Compare July 7, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize Makefiles across all meshery-academy repositories

2 participants