Skip to content

docs: drop "firewall" terminology#74

Merged
justin-layerv merged 1 commit into
mainfrom
justin/drop-firewall-terminology
Jun 7, 2026
Merged

docs: drop "firewall" terminology#74
justin-layerv merged 1 commit into
mainfrom
justin/drop-firewall-terminology

Conversation

@justin-layerv

Copy link
Copy Markdown
Collaborator

What

Removes "firewall" terminology from the SDK. LayerV is not a firewall company, and qURL's mechanism is better described as granting network access via the NHP knock — the wording the qURL MCP server already uses.

Changes (all docstring / comment / description — no behavior, API, type, or wire changes):

  • README.md — the "IP-scoped" bullet + the quickstart resolve comment
  • src/layerv_qurl/client.py, async_client.py — class example + resolve() docstrings
  • src/layerv_qurl/langchain.pyResolveQURLTool docstring + agent-facing description
  • src/layerv_qurl/types.pyAccessGrant docstring

AccessGrant fields are unchanged. Part of a cross-repo qURL conceptual-integrity pass (the integrations repo and the TypeScript SDK get the same treatment).

🤖 Generated with Claude Code

LayerV is not a firewall company; describe qURL's mechanism as granting
network access, not opening a firewall. Reword the README, the sync/async
client docstrings, the AccessGrant docstring, and the LangChain
ResolveQURLTool description to "grant network access" / "network access",
matching the qURL MCP server's wording. Docstring/comment/description-only
— no behavior, API, or wire changes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@claude

claude Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review: docs: drop "firewall" terminology

Reviewed the full diff. This is a clean, well-scoped docs-only change — swapping "firewall" terminology for "grant network access" wording across the README, sync/async client docstrings, the LangChain tool description, and the AccessGrant docstring.

Correctness & completeness

  • Verified there are no remaining firewall references anywhere in *.py or *.md (grep -rin firewall returns nothing). The pass is complete.
  • No behavior, API, type, or wire changes — AccessGrant fields are untouched, only the class docstring changed. The PR description's claim holds up.
  • The new wording is internally consistent across all five files and matches the stated qURL MCP server phrasing.

Wording nits (non-blocking)

  • README "IP-scoped" bullet now reads "IP-scoped — access is granted only to the requesting IP via NHP." Reads well.
  • The LangChain description is agent-facing and feeds tool selection. "gain network access to the protected resource" is clear and shouldn't affect tool-routing quality — good that it stays concrete.

Tests / CI

  • No test coverage needed: docstrings, comments, and a Markdown file carry no test surface. Worth a quick confirm that ruff check / mypy src/ still pass in CI, but nothing here should affect them.

Security / performance

  • N/A — no executable code paths touched.

LGTM. Nicely contained, accurate description, and the terminology is now consistent.

🤖 Generated with Claude Code

@justin-layerv justin-layerv self-assigned this Jun 7, 2026
@justin-layerv justin-layerv merged commit 337632a into main Jun 7, 2026
11 checks passed
@justin-layerv justin-layerv deleted the justin/drop-firewall-terminology branch June 7, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant