docs: drop "firewall" terminology#74
Merged
Merged
Conversation
LayerV is not a firewall company; describe qURL's mechanism as granting network access, not opening a firewall. Reword the README, the sync/async client docstrings, the AccessGrant docstring, and the LangChain ResolveQURLTool description to "grant network access" / "network access", matching the qURL MCP server's wording. Docstring/comment/description-only — no behavior, API, or wire changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Review: docs: drop "firewall" terminologyReviewed the full diff. This is a clean, well-scoped docs-only change — swapping "firewall" terminology for "grant network access" wording across the README, sync/async client docstrings, the LangChain tool description, and the Correctness & completeness
Wording nits (non-blocking)
Tests / CI
Security / performance
LGTM. Nicely contained, accurate description, and the terminology is now consistent. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes "firewall" terminology from the SDK. LayerV is not a firewall company, and qURL's mechanism is better described as granting network access via the NHP knock — the wording the qURL MCP server already uses.
Changes (all docstring / comment / description — no behavior, API, type, or wire changes):
README.md— the "IP-scoped" bullet + the quickstart resolve commentsrc/layerv_qurl/client.py,async_client.py— class example +resolve()docstringssrc/layerv_qurl/langchain.py—ResolveQURLTooldocstring + agent-facingdescriptionsrc/layerv_qurl/types.py—AccessGrantdocstringAccessGrantfields are unchanged. Part of a cross-repo qURL conceptual-integrity pass (the integrations repo and the TypeScript SDK get the same treatment).🤖 Generated with Claude Code