Draft
Add Append/HAppend type class pages explaining why ++ is used instead of +#2525
Conversation
Copilot
AI
changed the title
[WIP] Fix string concatenation representation issue
Add Append/HAppend type class pages explaining why ++ is used instead of +
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lean uses
++(not+) for string/list concatenation because+carries an expectation of commutativity (a + b = b + a), while concatenation is explicitly non-commutative. Mixing the two notations would create confusion.New pages
TypeClass/Append.lean— homogeneous++operator class; explains the commutativity distinction with concrete examples:Also shows a custom
Append MyListinstance and the internal expansion toHAppend.TypeClass/HAppend.lean— heterogeneous++operator class (parallel to existingHAdd/HMul); demonstrates customHAppend (List Nat) Nat (List Nat)and the stdlib'sHAppend (Array α) (List α) (Array α)instance.Updated pages
SUMMARY.lean— addsAppendandHAppendin alphabetical order within the TypeClass sectionType/String.lean,Type/List.lean— linksAppendinstead of just mentioning the name inline