Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces asynchronous support by implementing a new AsyncEither class that enables running and composing async operations with Either semantics. It also exposes the FoldingEither type for external use and provides comprehensive tests and documentation updates for the new functionality.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/either/either.ts | Exposes FoldingEither type to support asynchronous operations. |
| src/either/async-either.ts | Implements AsyncEither with async map, flatMap, and fold methods. |
| src/either/async-either.test.ts | Adds tests covering async functionality and error handling. |
| README.md | Updates documentation to include sections on AsyncEither usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Support async operations through to new AsyncEither, a wrapper of Either to work with promises.
Added/updated tests?
We encourage you to keep the quality of the code by creating test.
have not been included