Skip to content

Conversation

@kamilsa
Copy link
Collaborator

@kamilsa kamilsa commented Jan 14, 2026

🗒️ Description

Introduces aggregator role and subnet aggregation.

  • Every validator is assigned to one of the attestation subnets
  • Aggregators collect signatures that correspond to validators from their subnet
    * If aggregators collected 90% of signatures from their subnet by the beginning of slot 2, they produce aggregated attestation and propagate it into aggregation topic
  • Validators subscribe to aggregation topic, so that next block proposer may include committee aggregations into the block (without recursive aggregation for now)
Interval Devnet 2 Devnet 3
0 Aggregate signatures and put proofs into the block Put collected subnet proofs into the block
1 Cast a vote and publish to attestation topic Cast a vote and publish to attestation topic + publish to attestation_{subnet_id} topic
2 Update safe target Update safe target. Aggregator: aggregate collected signatures and broadcast a subnet proof into the aggregation topic
3 Attestations accepted Attestations accepted

Remaining work

- [ ] Process the case when aggregators did not observe enough signatures by the beginning of interval 2
- [ ] Add predicates for gossipsub propagations of aggregated signatures (e.g. do not propagate aggregation if we already observed the one for the same committee, but proving more validators signatures) Not needed for now as we have only a single aggregator per committee, so only one aggregation

  • Update to latest master

🔗 Related Issues or PRs

leanEthereum/pm#56
leanEthereum/pm#58

✅ Checklist

  • Ran tox checks to avoid unnecessary CI fails:
    uvx tox
  • Considered adding appropriate tests for the changes (will add in a separate PR)
  • Considered updating the online docs in the ./docs/ directory.

Copy link
Contributor

@jihoonsong jihoonsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Please excuse leaving some comments while it's still in draft. Just wanted to help iterate faster :)

# Configure the genesis state.
genesis_config = Config(
genesis_time=genesis_time,
attestation_subnet_count=AGGREGATION_COMMITTEE_COUNT,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit that I was the one who advocated for attestation committee, but based on the fact that validators only push their attestations to aggregators in their subnet without subscribing to it, I now think aggregation committee gives us slightly better description.

I don't mind whichever we choose—either attestation committee or aggregation committee—but I do think we need to stick to one thing consistently in the Lean spec and pq-devnet-3.md in the pm repo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong preference too, however I think the rationale for topic names in beacon chain spec is based on the type of messages that are being propagated to this topic. For consistency we should probably stick to the same logic and keep using attestation subnets and attestation committees

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great! In the same vein, what do you think about this one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, applied your suggestion

# Conflicts:
#	src/lean_spec/subspecs/forkchoice/store.py
#	src/lean_spec/subspecs/networking/__init__.py

When aggregation is added, aggregators will collect attestations and combine them.
Aggregated attestations will be broadcast separately.
Devnet-2 introduces signatures aggregation. Aggregators will collect attestations and combine them. Aggregated attestations will be broadcast separately.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Devnet-2 introduces signatures aggregation. Aggregators will collect attestations and combine them. Aggregated attestations will be broadcast separately.
Devnet-3 introduces signatures aggregation. Aggregators will collect attestations and combine them. Aggregated attestations will be broadcast separately.


In the devnet-3 design, however, there is one global subnet for signed
attestations propagation, in addition to publishing into per committee subnets.
This is due to 3SF-mini consensus design, that requires 2/3+ of all
Copy link
Contributor

@g11tech g11tech Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this global bit is not required, once the aggregtors publish signed attestations in the 2nd interval, they can be imported by all validators in the 3rd interval

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, without global topic for attestations, we might not be able to receive proofs in time to update safe target during interval 2:

  • Interval 0: block propagation
  • Interval 1: votes propagation
  • Interval 2: signatures aggregation (up to one second for 1000 validators in subnet with 1000sigs/second expected sigs aggregation rate) + proof distribution => No time for updating safe target => in next slot validator votes for old target

for data, validator_ids in data_to_validator_ids.items()
]

class SignedAggregatedAttestation(Container):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anshalshukla / @GrapeBaBa do we already have this type?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also better to use message, signature terminlogy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need aggregated bit vector here as well,

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need aggregated bit vector here as well,

AggregatedSignatureProof contains AggregationBits

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anshalshukla / @GrapeBaBa do we already have this type?

no

@unnawut unnawut added the specs Scope: Changes to the specifications label Jan 23, 2026
@unnawut unnawut added this to the pq-devnet-3 milestone Jan 23, 2026

| Topic Name | Message Type | Encoding |
|------------------------------------------------------------|-----------------------------|--------------|
| /lean/consensus/devnet3/blocks/ssz_snappy | SignedBlockWithAttestation | SSZ + Snappy |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

original prefix is /leanconsensus, this is an expected change /lean/consensus?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no.
Thanks for noticing. Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

specs Scope: Changes to the specifications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants