Skip to content

Add fork choice store pruning test#604

Open
Itodo-S wants to merge 2 commits intoleanEthereum:mainfrom
Itodo-S:fix-issue-567-store-pruning
Open

Add fork choice store pruning test#604
Itodo-S wants to merge 2 commits intoleanEthereum:mainfrom
Itodo-S:fix-issue-567-store-pruning

Conversation

@Itodo-S
Copy link
Copy Markdown
Contributor

@Itodo-S Itodo-S commented Apr 13, 2026

Summary

Add a fork choice filler for store pruning on finalization.

Closes #567

What changed

  • Add a devnet fork choice test covering pruning after finalization advances to slot 3
  • Verify stale attestation data targeting slots 1, 2, and 3 is removed
  • Verify attestation data targeting slots 4 and 5 is preserved
  • Extend StoreChecks with exact target-slot assertions for raw, new, and known attestation pools
  • Update fork choice attestation steps to retain raw gossip signatures so pruning can be tested end to end

Why

Pruning stale attestation data is required to avoid unbounded memory growth and to ensure finalized targets no longer influence fork choice state.

@Itodo-S Itodo-S force-pushed the fix-issue-567-store-pruning branch from 3949f9c to 621bdec Compare April 13, 2026 22:07
@tcoratger
Copy link
Copy Markdown
Collaborator

@Itodo-S Looks like test vectors are failing, can you check?

@Itodo-S
Copy link
Copy Markdown
Contributor Author

Itodo-S commented Apr 14, 2026

@tcoratger, I have worked on this and pushed already; that should be resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(fc): finalization prunes stale attestation signatures from store

2 participants