feat: add lock file maintenance to automerge preset#83
feat: add lock file maintenance to automerge preset#83JonaLoefflerLeanix wants to merge 2 commits intomainfrom
Conversation
JonaLoefflerLeanix
requested review from
StefanKuerten1234,
kostas-petrakis,
liudmyla-b,
r0binary-sap and
timovankissing-leanix
|
📊 Survey: Please help us track internal AI adoption. This is not for evaluation, only for metrics. You can update this anytime before merge.
🧑💻 If AI was used, what was it mainly used for?
Thank you in advance for your feedback.💙🙏🎉 |
SummaryThe following content is AI-generated and provides a summary of the pull request: Add Lock File Maintenance Automerge to Renovate PresetNew Feature✨ Extends the shared Changes
PR Bot InformationVersion:
|
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
The PR correctly adds lockFileMaintenance automerge support and updates the README, but the schedule expression * 9-13 * * 1-5 (copied from the existing block) has an overly broad minutes field — using a human-readable Renovate schedule string or fixing the minutes position to 0 would make the intent unambiguous.
PR Bot Information
Version: 1.20.23
- LLM:
anthropic--claude-4.6-sonnet - Event Trigger:
pull_request.opened - Correlation ID:
a363e753-d313-4826-b2fd-082505cf867d - File Content Strategy: Full file content
| ], | ||
| "lockFileMaintenance": { | ||
| "schedule": [ | ||
| "* 9-13 * * 1-5" |
There was a problem hiding this comment.
Bug: Cron schedule * 9-13 * * 1-5 fires every minute within the 9–13 window
The * in the minutes field means "every minute of every hour from 9 to 13". While Renovate debounces actual PR actions, this is semantically wrong and mirrors the same issue already present in the packageRules block above.
Renovate's schedule parser also accepts plain human-readable strings, which are much clearer. Consider using the explicit human-readable form instead:
"schedule": ["after 9am and before 1pm on Monday through Friday"]If you prefer to keep the cron-style syntax, use 0 (not *) in the minutes position so it triggers once per hour boundary rather than every minute.
| "* 9-13 * * 1-5" | |
| "after 9am and before 1pm on Monday through Friday" |
Double-check suggestion before committing. Edit this comment for amendments.
Please provide feedback on the review comment by checking the appropriate box:
- 🌟 Awesome comment, a human might have missed that.
- ✅ Helpful comment
- 🤷 Neutral
- ❌ This comment is not helpful
|
Hey Jona, nice contribution. A few remarks to consider:
|
Move lock file maintenance automerge config from a separate lockFileMaintenance block into the existing packageRules entry by adding lockFileMaintenance to matchUpdateTypes.
Yes, this was meant more as a suggestion and to get the ball rolling. Happy to hand it over to you 🙏 |
2 participants
Summary
lockFileMaintenanceautomerge configuration to the sharedautomerge.json5presetMotivation
Lock file maintenance PRs are low-risk (they only update the lock file without changing version ranges) but were not covered by the
matchUpdateTypespackage rule sincelockFileMaintenanceis a separate Renovate config key, not a standard update type.Test plan