fix(olean_diff): report error when PR head oleans are missing#30
Open
bryangingechen wants to merge 1 commit intomasterfrom
Open
fix(olean_diff): report error when PR head oleans are missing#30bryangingechen wants to merge 1 commit intomasterfrom
bryangingechen wants to merge 1 commit intomasterfrom
Conversation
Previously the script only validated that the base (merge-base) directory had oleans, but not the head (PR) directory. If the head had no oleans, classify_modules returned an empty head set and every base module appeared as "removed", producing a confusing report. Add a symmetric has_oleans check for the head directory and emit the same style of error comment the base check already uses. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the script only validated that the base (merge-base) directory had oleans, but not the head (PR) directory. If the head had no oleans, classify_modules returned an empty head set and every base module appeared as "removed", producing a confusing report.
Add a symmetric has_oleans check for the head directory and emit the same style of error comment the base check already uses.
Prepared with Claude code.