Skip to content

perf: lower priority of NormedAlgebraicFoo -> AlgebraicFoo instances #36844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grunweg wants to merge 1 commit into from
+6 −0
Closed

perf: lower priority of NormedAlgebraicFoo -> AlgebraicFoo instances #36844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Mathlib/Analysis/Normed/Group/Defs.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,9 @@ class NormedGroup (E : Type*) extends Norm E, Group E, MetricSpace E where
/-- The distance function is induced by the norm. -/
dist_eq : ∀ x y, dist x y = ‖x⁻¹ * y‖ := by aesop

/- TODO: comment on this change! -/
attribute [instance 900] NormedAddGroup.toAddGroup SeminormedAddGroup.toAddGroup

/-- A seminormed group is an additive group endowed with a norm for which `dist x y = ‖-x + y‖`
defines a pseudometric space structure. -/
class SeminormedAddCommGroup (E : Type*) extends Norm E, AddCommGroup E,
Expand Down
3 changes: 3 additions & 0 deletions Mathlib/Analysis/Normed/Module/Basic.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,9 @@ class NormedAlgebra (𝕜 : Type*) (𝕜' : Type*) [NormedField 𝕜] [Seminorme
Algebra 𝕜 𝕜' where
norm_smul_le : ∀ (r : 𝕜) (x : 𝕜'), ‖r • x‖ ≤ ‖r‖ * ‖x‖

/- TODO comment on this change! -/
attribute [instance 900] NormedAlgebra.toAlgebra

attribute [inherit_doc NormedAlgebra] NormedAlgebra.norm_smul_le

variable (𝕜')
Expand Down
Loading