Skip to content

[Merged by Bors] - chore(Geometry/Manifold/Immersion): minor tweaks#38162

Closed
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:immersion-fixups
Closed

[Merged by Bors] - chore(Geometry/Manifold/Immersion): minor tweaks#38162
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:immersion-fixups

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Apr 17, 2026

  • remove superfluous noncomputable
  • golf one proof very slightly
  • a few wording improvements to the module doc-string (content-neutral)

Noticed while reviewing #35122.


Open in Gitpod

@grunweg grunweg added easy < 20s of review time. See the lifecycle page for guidelines. t-differential-geometry Manifolds etc labels Apr 17, 2026
@github-actions
Copy link
Copy Markdown

PR summary a8af750656

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Apr 17, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Apr 17, 2026
- remove superfluous noncomputable
- golf one proof very slightly
- a few wording improvements to the module doc-string (content-neutral)

Noticed while reviewing #35122.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 17, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(Geometry/Manifold/Immersion): minor tweaks [Merged by Bors] - chore(Geometry/Manifold/Immersion): minor tweaks Apr 17, 2026
@mathlib-bors mathlib-bors Bot closed this Apr 17, 2026
jessealama pushed a commit to jessealama/mathlib4 that referenced this pull request May 2, 2026
…y#38162)

- remove superfluous noncomputable
- golf one proof very slightly
- a few wording improvements to the module doc-string (content-neutral)

Noticed while reviewing leanprover-community#35122.
gaetanserre pushed a commit to gaetanserre/mathlib4 that referenced this pull request May 5, 2026
…y#38162)

- remove superfluous noncomputable
- golf one proof very slightly
- a few wording improvements to the module doc-string (content-neutral)

Noticed while reviewing leanprover-community#35122.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants