-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(CategoryTheory/Monoidal): MulAction induced by a ModObj
#38336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chrisflav
wants to merge
10
commits into
leanprover-community:master
Choose a base branch
from
chrisflav:mulactionobj
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+153
−3
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5e3058f
mul action objects
chrisflav 71adca9
mk_all
chrisflav 6b64143
Merge branch 'master' into mulactionobj
chrisflav 62e6c5f
Merge branch 'master' into mulactionobj
chrisflav 3144f64
Merge branch 'master' into mulactionobj
chrisflav 965951a
fix
chrisflav 07a79eb
fix
chrisflav ef7b496
add name
chrisflav 69c4d91
Merge remote-tracking branch 'upstream/master' into mulactionobj
chrisflav 2fe4847
Update Mathlib/CategoryTheory/Monoidal/Cartesian/Mod.lean
chrisflav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this and line 67 to
achieves what you want to do without the warning, I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I don't understand why the previous line doesn't do the same thing as these two lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed in #38994 (see also #38336 (comment), where I asked Jovan a similar question). With that fix, these two lines can just be removed again and line 67 can stay as is.
I think it is slightly nicer to have the
set_optionversion as is for now as a reminder that it should be cleaned up when #38994 lands, but if you prefer your version in the meantime I am happy to change it.