feat(to_additive): support (attr := reassoc)#38994
Open
JovanGerb wants to merge 3 commits intoleanprover-community:masterfrom
Open
feat(to_additive): support (attr := reassoc)#38994JovanGerb wants to merge 3 commits intoleanprover-community:masterfrom
(attr := reassoc)#38994JovanGerb wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
PR summary 3144a34bdaImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
chrisflav
approved these changes
May 6, 2026
Member
chrisflav
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me, but I am in no way competent to review this.
Comment on lines
-150
to
-152
| set_option linter.existingAttributeWarning false in | ||
| attribute [to_additive existing] IsModHom.smul_hom_assoc | ||
|
|
Member
There was a problem hiding this comment.
There is the same issue in Monoidal/Mon.lean. Could you please also fix that one?
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses
registerGeneratingAttr, so thatto_additive (attr := reassoc)also tags the_assoclemma withto_additive.This interacts awkwarly with
to_dual (attr := reassoc), because in that case, thereassocattribute is responsible for handling theto_dualattribute. This is solved by adding a check so that we only insert a new translation if it doesn't already exist (e.g. becausereassoccould have added it).