Skip to content

chore(ModelTheory): fix hypo of realize_liftAt#39004

Open
zhuyizheng wants to merge 1 commit intoleanprover-community:masterfrom
zhuyizheng:fix-realize-liftat
Open

chore(ModelTheory): fix hypo of realize_liftAt#39004
zhuyizheng wants to merge 1 commit intoleanprover-community:masterfrom
zhuyizheng:fix-realize-liftat

Conversation

@zhuyizheng
Copy link
Copy Markdown
Contributor

changes the hypo of realize_liftAt from the incorrect (hmn : m + n' ≤ n + 1) to the correct (hmn : m ≤ n)


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

PR summary c033d3e388

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@github-actions github-actions Bot added the t-logic Logic (model theory, etc) label May 6, 2026
@plp127
Copy link
Copy Markdown
Contributor

plp127 commented May 6, 2026

this seems to be not strictly stronger?

@zhuyizheng
Copy link
Copy Markdown
Contributor Author

zhuyizheng commented May 7, 2026

this seems to be not strictly stronger?

The strongest form is m ≤ n ∨ n' = 0, but

  1. mathematically, liftAt makes sense only when m ≤ n;
  2. if anyone ever needs n' = 0, the left hand side (φ.liftAt n' m).Realize v xs should immediately be simplified to φ.Realize v xs. The simplification from φ.liftAt 0 m to φ deserves a separate lemma with a @[simp] attribute, in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-logic Logic (model theory, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants