Skip to content

feat: set dsimp := false in @[to_app]#39009

Open
JovanGerb wants to merge 1 commit intoleanprover-community:masterfrom
JovanGerb:Jovan-to_app-dsimp
Open

feat: set dsimp := false in @[to_app]#39009
JovanGerb wants to merge 1 commit intoleanprover-community:masterfrom
JovanGerb:Jovan-to_app-dsimp

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

@JovanGerb JovanGerb commented May 6, 2026

This PR sets dsimp := false in the simp only done by to_app. This avoids doing unintentional rewrites, and makes it more robust to changes in dsimp.

https://leanprover.zulipchat.com/#narrow/channel/428973-nightly-testing/topic/nightly.23215.20adaptations.20for.20nightly-2026-05-03/near/593294096


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

PR summary 4efb9eabf5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant