chore(*): small fixes for backward.inferInstanceAs tech debt#39012
Open
Vierkantor wants to merge 1 commit intoleanprover-community:masterfrom
Open
chore(*): small fixes for backward.inferInstanceAs tech debt#39012Vierkantor wants to merge 1 commit intoleanprover-community:masterfrom
backward.inferInstanceAs tech debt#39012Vierkantor wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
This PR contains a few more fixes/workaround for `backward.inferInstanceAs` issues. By explicitly constructing the instance we ensure the right defeqs hold. There also seems to be one place where we can remove the `set_option` without any downstream breakage.
PR summary 8885ca9642Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a few more fixes/workaround for
backward.inferInstanceAsissues. By explicitly constructing the instance we ensure the right defeqs hold. There also seems to be one place where we can remove theset_optionwithout any downstream breakage.