feat(Regularized): prove to_SupRegularized and of_Subadditive#1022
Merged
jstoobysmith merged 2 commits intoleanprover-community:masterfrom May 5, 2026
Merged
Conversation
Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
jstoobysmith
reviewed
Apr 6, 2026
Comment on lines
+124
to
+126
| have liminf_neg : Filter.liminf fn Filter.atTop = -(Filter.limsup (-fn) Filter.atTop) := by | ||
| simp [Filter.limsup_eq, Filter.liminf_eq, Real.sInf_def] | ||
| exact Real.ext_cauchy (congrArg Real.cauchy liminf_neg) |
Member
There was a problem hiding this comment.
Suggested change
| have liminf_neg : Filter.liminf fn Filter.atTop = -(Filter.limsup (-fn) Filter.atTop) := by | |
| simp [Filter.limsup_eq, Filter.liminf_eq, Real.sInf_def] | |
| exact Real.ext_cauchy (congrArg Real.cauchy liminf_neg) | |
| refine Real.ext_cauchy (congrArg Real.cauchy ?_) | |
| simp [Filter.limsup_eq, Filter.liminf_eq, Real.sInf_def] |
Haven't checked, and will leave it to the QuantumInfo folk for a proper review. But this might be shorter.
jstoobysmith
added
the
awaiting-author
jstoobysmith
approved these changes
May 4, 2026
Member
jstoobysmith
left a comment
jstoobysmith
left a comment
There was a problem hiding this comment.
I've approved this, as this is no doubt an improvement.
jstoobysmith
approved these changes
May 5, 2026
Member
jstoobysmith
left a comment
jstoobysmith
left a comment
There was a problem hiding this comment.
Approving - and will merge now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds proofs autoformalised by @Aristotle-Harmonic.
Co-authored-by: Aristotle (Harmonic) aristotle-harmonic@harmonic.fun