feat(HermitianMat/Proj): add projector positivity, kernel, and posPart=0 lemmas#1074
Merged
jstoobysmith merged 1 commit intoleanprover-community:masterfrom May 5, 2026
Merged
Conversation
jstoobysmith
reviewed
May 4, 2026
Member
jstoobysmith
left a comment
jstoobysmith
left a comment
There was a problem hiding this comment.
Couple of small comments - otherwise this looks good
| @@ -8,6 +8,7 @@ module | |||
| public import QuantumInfo.ForMathlib.HermitianMat.CFC | |||
|
|
|||
Member
There was a problem hiding this comment.
I think this file should be named “Projector”. If easy could we change it? No worries if not.
| erw [ Subtype.mk_eq_mk ]; | ||
| ext i j; simp [ LinearMap.toMatrix_apply, Matrix.one_apply ] ; | ||
|
|
||
| theorem projector_nonneg : 0 ≤ projector S := by |
Member
There was a problem hiding this comment.
Most of the QuantumInfo “theorem” will eventually be changed to “lemma” could we use “lemma” here and throughout the changes
jstoobysmith
approved these changes
May 5, 2026
Member
jstoobysmith
left a comment
jstoobysmith
left a comment
There was a problem hiding this comment.
Let me actually approve this one, as my comments can be left to a future PR. I think this is undeniably an improvement, and therefore should be merged. I will do so shortly.
jstoobysmith
added
the
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proof wanted to theorem