feat(ClassicalMechanics/HarmonicOsciallator): a few refactors and a new lemma#1079
Merged
jstoobysmith merged 8 commits intoleanprover-community:masterfrom May 5, 2026
Merged
Conversation
jstoobysmith
reviewed
May 4, 2026
Member
jstoobysmith
left a comment
jstoobysmith
left a comment
There was a problem hiding this comment.
Couple of comments, but looks like a very nice PR :).
jstoobysmith
reviewed
May 4, 2026
jstoobysmith
reviewed
May 4, 2026
jstoobysmith
reviewed
May 5, 2026
jstoobysmith
approved these changes
May 5, 2026
Member
jstoobysmith
left a comment
jstoobysmith
left a comment
There was a problem hiding this comment.
Approved - many thanks and congrats on your first PR :). Will merge shortly.
jstoobysmith
added
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am an undergraduate physics student with a bit of lean experience and I just came across physlib. I was looking around the files and found a few things that could be expressed a bit cleaner (namely using @[ext] annotations).
I also added a new lemma about the periodicity of the trajectory of a harmonic oscillator. For this, i introduced the definition of the period T of a harmonic oscillator. Please give me some feedback if this is desirable here or if there are better design choices.