refactor: introduce grind sets for Automata (see issue #308)#385
Draft
xvade wants to merge 2 commits intoleanprover:mainfrom
Draft
refactor: introduce grind sets for Automata (see issue #308)#385xvade wants to merge 2 commits intoleanprover:mainfrom
xvade wants to merge 2 commits intoleanprover:mainfrom
Conversation
Open
chenson2018
reviewed
Mar 2, 2026
| #grind_lint skip Cslib.Automata.DA.buchi_eq_finAcc_omegaLim | ||
| #grind_lint skip Cslib.LTS.MTr.stepL | ||
| #grind_lint skip Cslib.LTS.STr.trans_τ | ||
| #grind_lint skip Cslib.Automata.DA.FinAcc.toNAFinAcc_language_eq |
Collaborator
There was a problem hiding this comment.
Having to remove these is a pretty serious tradeoff I wasn't expecting. I have asked on Zulip about this, let's see what is said there before I review the rest of this closely.
| "subDir": null, | ||
| "scope": "leanprover-community", | ||
| "rev": "9b1001cbdbfe51cbc92398637317609eb7bbf139", | ||
| "rev": "a237616fe5742014bd87366490691a7c1de9d1a7", |
Collaborator
There was a problem hiding this comment.
Generally PRs should not change the manifest (I assume this was via lake update).
fmontesi
requested changes
Mar 3, 2026
| public import Mathlib.Init | ||
| public import Mathlib.Tactic.Common | ||
|
|
||
| register_grind_attr automata |
Collaborator
There was a problem hiding this comment.
This means that:
- We get to write
grind [automata], which I like. - We annotate theorems with
@[automata], which I'm not sure I like. It doesn't communicate that we're making a grind annotation. Perhaps we should consider a prefix, likegrind_(orgrind:, if it's supported)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
automatagrind attribute and replaces most instances ofscoped grindin the Automata directory with it. Updates proofs to match.