fix: perform severity overrides before counting errors#13589
Merged
Kha merged 1 commit intoleanprover:masterfrom May 5, 2026
Merged
fix: perform severity overrides before counting errors#13589Kha merged 1 commit intoleanprover:masterfrom
Kha merged 1 commit intoleanprover:masterfrom
Conversation
This PR ensures that the `lean --error=tag` flag actually sets a non-zero exit code on promoted errors. Fixes leanprover#13588
Contributor
Author
|
changelog-compiler |
github-actions
Bot
added
changelog-compiler
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Kha
added
changelog-other
and removed
changelog-compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
lean --error=tagflag actually sets a non-zero exit code on promoted errors.Closes #13588, fixing the feature introduced in #6362.