feat: expose fields required for implementing linters outside of Lean core with detailed auto-fixes and diagnostic tags #13610
Draft
wvhulle wants to merge 4 commits intoleanprover:masterfrom
Draft
Conversation
wvhulle
force-pushed
the
message-diagnostic-fields
branch
from
540709f to
7eadf90
Compare
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Pulls these LSP types into their own prelude-friendly modules so downstream code (linters, widget bridges) can depend on them without importing the full Diagnostics module.
Adds the three diagnostic fields to Message and threads them through Log and the InteractiveDiagnostic widget bridge so the LSP layer can emit them. Also preserves infoState on linter messages so consumers can attach quick-fix code actions.
Updates Lean's built-in deprecated and unused-variable linters to use the new diagnosticTags field so editors render strikethrough/grey appropriately. Demonstrates the consumer pattern downstream linters will follow.
wvhulle
force-pushed
the
message-diagnostic-fields
branch
from
7eadf90 to
b41cf5f
Compare
wvhulle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes metadata otherwise inaccessible to users implementing linters such as diagnostic tags and data. This allows defining diagnostics in more detail as well as replacements, code actions and custom formatting of deprecated or unused syntax.
See how I am currently using this at https://codeberg.org/wvhulle/heron
This PR is kind of more urgent compared to my other PRs. Without direct access to this data, I have to resort to workarounds which don't work nicely with most editors.
Nix changes can be dropped. Another PR is open for them.