fix: reject attribute uses whose module is reachable only via IR#13613
Draft
Kha wants to merge 2 commits intoleanprover:masterfrom
Draft
fix: reject attribute uses whose module is reachable only via IR#13613Kha wants to merge 2 commits intoleanprover:masterfrom
Kha wants to merge 2 commits intoleanprover:masterfrom
Conversation
This PR makes the elaborator reject `@[foo]` when the module that registers `foo` is reachable only via a `meta import` chain, with an error pointing at the missing non-`meta` `import`. Previously such uses silently elaborated but caused `shake --fix` to flip-flop on successive runs (issue leanprover#13599) because the missing `metaExt` left an attribute's recorded import stuck as `meta`. The check fires only for `regular_initialize`-registered attributes (i.e. user-defined ones, not `builtin_initialize` core attributes) whose home module has `irPhases == .comptime`.
github-actions
Bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
github-actions
Bot
added
the
mathlib4-nightly-available
mathlib-lean-pr-testing
Bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 3, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the elaborator reject
@[foo]when the module that registersfoois not visibly imported into the current file but merely loaded as IR. Previously such uses silently elaborated but led to divergence of cmdline and server behavior and causedlake shake --fixto flip-flop on successive runs (#13599).