fix: create well-spanned syntax on verso blocks#700
Merged
ejgallego merged 1 commit intoleanprover:mainfrom Feb 5, 2026
Merged
fix: create well-spanned syntax on verso blocks#700ejgallego merged 1 commit intoleanprover:mainfrom
ejgallego merged 1 commit intoleanprover:mainfrom
Conversation
ejgallego
force-pushed
the
fix_doc_syntax_setup
branch
from
c90d0cc to
9e3f79d
Compare
ejgallego
added a commit
to ejgallego/verso
that referenced
this pull request
Jan 22, 2026
This avoids spurious infoview display of the internal elaborated constant type. This bug is only observable after applying the fix in leanprover#700 ; will wait for leanprover#700 and leanprover#699 to merge this so we can properly provide a test. Co-authored-by: David Thrane Christiansen <david@lean-fro.org>
ejgallego
force-pushed
the
fix_doc_syntax_setup
branch
2 times, most recently
from
a5b5ab0 to
58a1f8c
Compare
ejgallego
added a commit
to ejgallego/verso
that referenced
this pull request
Jan 29, 2026
This avoids spurious infoview display of the internal elaborated constant type. This bug is only observable after applying the fix in leanprover#700 ; will wait for leanprover#700 and leanprover#699 to merge this so we can properly provide a test. Co-authored-by: David Thrane Christiansen <david@lean-fro.org>
ejgallego
force-pushed
the
fix_doc_syntax_setup
branch
from
58a1f8c to
127e30a
Compare
ejgallego
added a commit
to ejgallego/verso
that referenced
this pull request
Feb 3, 2026
This avoids spurious infoview display of the internal elaborated constant type. This bug is only observable after applying the fix in leanprover#700 ; will wait for leanprover#700 and leanprover#699 to merge this so we can properly provide a test. Co-authored-by: David Thrane Christiansen <david@lean-fro.org>
Collaborator
|
Looks like we'll need to do a bit more to make this work for PRs from forks. We can save an artifact and then run a pull_request_target workflow that will have secrets access. |
Collaborator
|
I took the liberty of merging |
We did push `genre` and `title` to the last block syntax, but this broke the infotree span invariant, causing problems when retrieving the goals. Co-authored-by: David Thrane Christiansen <david@lean-fro.org>
ejgallego
force-pushed
the
fix_doc_syntax_setup
branch
from
6743e67 to
e5b712c
Compare
Contributor
Author
Thanks David! |
Contributor
|
Preview for this PR is ready! 🎉 |
Contributor
Author
|
[Assuming this is ready as we wrote the code together, will merge today unless more feedback is raised] |
ejgallego
added a commit
to ejgallego/verso
that referenced
this pull request
Feb 5, 2026
This avoids spurious infoview display of the internal elaborated constant type. This bug is only observable after applying the fix in leanprover#700 ; will wait for leanprover#700 and leanprover#699 to merge this so we can properly provide a test. Co-authored-by: David Thrane Christiansen <david@lean-fro.org>
Collaborator
|
Please merge as soon as you feel ready! |
ejgallego
added a commit
to ejgallego/verso
that referenced
this pull request
Feb 5, 2026
This avoids spurious infoview display of the internal elaborated constant type. This bug is only observable after applying the fix in leanprover#700 ; will wait for leanprover#700 and leanprover#699 to merge this so we can properly provide a test. Co-authored-by: David Thrane Christiansen <david@lean-fro.org>
ejgallego
added a commit
to ejgallego/verso
that referenced
this pull request
Feb 6, 2026
This avoids spurious infoview display of the internal elaborated constant type. This bug is only observable after applying the fix in leanprover#700 ; will wait for leanprover#700 and leanprover#699 to merge this so we can properly provide a test. Co-authored-by: David Thrane Christiansen <david@lean-fro.org>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
…#707) This avoids spurious infoview display of the internal elaborated constant type. This bug is only observable after applying the fix in #700 ; will wait for #700 and #699 to merge this so we can properly provide a test. Co-authored-by: David Thrane Christiansen <david@lean-fro.org> --------- Co-authored-by: David Thrane Christiansen <david@lean-fro.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did push
genreandtitleto the last block syntax, but thisbroke the infotree span invariant, causing problems when retrieving
the goals.
Co-authored-by: David Thrane Christiansen david@lean-fro.org