fix: handle closed PR status not showing properly#102
Open
Rizina wants to merge 2 commits intoleapfrogtechnology:masterfrom
Open
fix: handle closed PR status not showing properly#102Rizina wants to merge 2 commits intoleapfrogtechnology:masterfrom
Rizina wants to merge 2 commits intoleapfrogtechnology:masterfrom
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
sbimochan
approved these changes
Nov 5, 2024
| <MergeStatus open={pullRequest.state === ISSUE_STATUS.OPEN} merged={pullRequest.state === ISSUE_STATUS.CLOSED} /> | ||
| <MergeStatus | ||
| open={pullRequest.state === ISSUE_STATUS.OPEN} | ||
| merged={pullRequest.state === ISSUE_STATUS.CLOSED && pullRequest.pull_request.merged_at} |
Member
There was a problem hiding this comment.
Suggested change
| merged={pullRequest.state === ISSUE_STATUS.CLOSED && pullRequest.pull_request.merged_at} | |
| merged={pullRequest.state === ISSUE_STATUS.CLOSED && !!pullRequest.pull_request.merged_at} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101
Updated the code to properly identify the closed vs merged PRs