Skip to content

Conversation

@sharma-anushka
Copy link
Contributor

Summary

Fixes the vertical alignment of external links on the Settings > About Studio page to ensure they are visually consistent with other links and surrounding text.

Manual Verification

Untitled design

References

Fixes #5671

@learning-equality-bot
Copy link

👋 Thanks for contributing!

We will assign a reviewer within the next two weeks. In the meantime, please ensure that:

  • You ran pre-commit locally
  • All issue requirements are satisfied
  • The contribution is aligned with our Contributing guidelines. Pay extra attention to Using generative AI. Pull requests that don't follow the guidelines will be closed.

We'll be in touch! 😊

@MisRob MisRob changed the title Fixes : Issue #5671 Fix misaligned links on About Studio page Jan 29, 2026
@@ -159,7 +159,9 @@
}
.kexternal-redirect {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of margin-left makes sense. I don't follow why other styles needed to be add. If you remove the whole kexternal-redirect class, what will happen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that case @MisRob
Removing the .kexternal-redirect class entirely also fixes the alignment issue.

I interpreted that the SVG was causing the misalignment and so I thought to give a flex, which on inspection was getting overriden and so I used the important keyword.
Removing the class altogether didnt stike my mind.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the .kexternal-redirect class entirely also fixes the alignment issue.

Okay, let's do it this way then please. Whenever possible, it's always better to get rid of code ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I agree.

@MisRob MisRob self-assigned this Jan 29, 2026
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, and I've just confirmed the fix in my local Studio. Thank you @sharma-anushka.

@MisRob MisRob merged commit 24c820a into learningequality:unstable Jan 29, 2026
13 checks passed
@sharma-anushka sharma-anushka deleted the fix-issue-5671 branch January 29, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix misaligned links on About Studio page

2 participants