-
Notifications
You must be signed in to change notification settings - Fork 280
Fix misaligned links on About Studio page #5675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misaligned links on About Studio page #5675
Conversation
|
👋 Thanks for contributing! We will assign a reviewer within the next two weeks. In the meantime, please ensure that:
We'll be in touch! 😊 |
| @@ -159,7 +159,9 @@ | |||
| } | |||
| .kexternal-redirect { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of margin-left makes sense. I don't follow why other styles needed to be add. If you remove the whole kexternal-redirect class, what will happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested that case @MisRob
Removing the .kexternal-redirect class entirely also fixes the alignment issue.
I interpreted that the SVG was causing the misalignment and so I thought to give a flex, which on inspection was getting overriden and so I used the important keyword.
Removing the class altogether didnt stike my mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the .kexternal-redirect class entirely also fixes the alignment issue.
Okay, let's do it this way then please. Whenever possible, it's always better to get rid of code ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I agree.
MisRob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, and I've just confirmed the fix in my local Studio. Thank you @sharma-anushka.
Summary
Fixes the vertical alignment of external links on the
Settings>About Studiopage to ensure they are visually consistent with other links and surrounding text.Manual Verification
References
Fixes #5671