(#16) Allow customization of Admin panel colors and logo#28
Merged
paranoicsan merged 2 commits intomasterfrom Feb 20, 2026
Merged
(#16) Allow customization of Admin panel colors and logo#28paranoicsan merged 2 commits intomasterfrom
paranoicsan merged 2 commits intomasterfrom
Conversation
0f886c1 to
05058ac
Compare
paranoicsan
reviewed
Feb 19, 2026
Contributor
paranoicsan
left a comment
There was a problem hiding this comment.
Looks good! Thank you! Added some comments, please let me know what do you think.
05058ac to
ac7fbfd
Compare
- Add settings model and DB schema - Implement new LogoUploader to handle admin panel logo customization - Implement appearance setting edit & logo upload UI
ac7fbfd to
67d7ae0
Compare
### Harden Setting model value column
- Add null: false and default: {} to settings.value in migration
- Remove presence validation for value from model (blank? rejects {})
- Guard Setting.set against nil to prevent NOT NULL violations
- Add specs for nil and empty hash handling in Setting.set
### Move image deletion logic from SettingsController to ImageUploader
- Extract delete_by_url class method to ImageUploader with support for local and S3 files
- Remove duplicate deletion methods from SettingsController
- Add specs for ImageUploader.delete_by_url
Signed-off-by: Alexander Kuznetsov <paranoic.san@gmail.com>
67d7ae0 to
0bf671f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds customization options for the admin panel:
lcms-core-appearance-ui.mov
The changes are broken into logical commits for easier review but can be squash merged.
Issue
Refs: #16