Initial exploration into an async check#73
Open
davidnormo wants to merge 1 commit intoleebyron:masterfrom
Open
Initial exploration into an async check#73davidnormo wants to merge 1 commit intoleebyron:masterfrom
davidnormo wants to merge 1 commit intoleebyron:masterfrom
Conversation
Owner
|
Thanks for doing this! Very cool to see the async check implementation out there, that definitely simplifies some things. Some next steps I can see:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #45
All credit for the async quick-check implementation goes to promesa-check ⭐️
This PR adds this behind a new function:
checkAsync. This acts exactly the same ascheckexcept that the property function needs to return a promise.Ideally I'd prefer
checkto be able to accept both sync and async properties, which I may work on, but thought I'd share this for some early feedback