better handling of svyglm objects and factor predictors#159
Open
tzoltak wants to merge 2 commits intoleeper:mainfrom
Open
better handling of svyglm objects and factor predictors#159tzoltak wants to merge 2 commits intoleeper:mainfrom
tzoltak wants to merge 2 commits intoleeper:mainfrom
Conversation
Author
|
And #132 is also solved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure the following before submitting a PR:
[v] if suggesting code changes or improvements, open an issue first
[v] for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
[v] for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
[v] if changing documentation, edit files in
/Rnot/manand rundevtools::document()to update documentation[v] add code or new test files to
/testsfor any new functionality or bug fix[v] make sure
R CMD checkruns without error before submitting the PRMore Straightforward handling of "svyglm" objects from package survey (remove the
designargument frommargins.svyglm()). design in margins.svyglm #124Better handling of factor predictors.
atand factors #116, margins(at = ) fails when only one factor level is specified #121, Problem with factors that have unused levels #125Added
coef()method for "margins" class. Feature request: coef method for margins objects #131