Open
Conversation
leezer3
force-pushed
the
AnimatedRailIndex
branch
from
8f543c6 to
e1d65e1
Compare
leezer3
force-pushed
the
master
branch
3 times, most recently
from
5f23a6d to
a53fd14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1009
Unfinished WIP.
Current progress:
The creation of objects (in master) uses a large number of parameters, which are often passed through two or three levels of function calls.
This refactors them into a single helper struct.
Next job is to save the rail index in the animated object, and provide an appropriate function accessor for them.
Risks:
Minor, however this changes a lot of places. If we manage to get the starting / ending distances bugged somewhere, this is likely to lead to visibility gliches.
Needs careful testing....