Change: Improve handling of excessively large StructureIdx values#186
Merged
Change: Improve handling of excessively large StructureIdx values#186
Conversation
Owner
Author
|
Fiddle, some of the Travis builds are failing because using as an inline out isn't actually supported until C# 7.0, despite the fact that this is just a syntatic little push.... Will fix that, and probably port to Route Viewer later. |
78a7f5d to
bbc2467
Compare
Owner
Author
|
Hmm. This is not logged anywhere either, which isn't good, and wasn't before this was started either. TODO:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #185
Needs some more testing to make sure nothing has broken.
Specifically:
Test what happens when an object indices is declared twice.==> Broken, see below.Do we port to Route Viewer? New: Basic route viewer mode for the main program #165 may negate the need for this, but not sure how far away that is.